✨ Use same kustomize version as upstream cluster-api #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
displague
reviewed
Jun 27, 2024
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
- Align version of kustomize to upstream cluster-api - Use upstream method to build kustomize with go install - Add yq to hack tools - Use yq to fix calico yaml formatting (this is the best upstream recommendation to fix kustomize yaml mangling) Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
cprivitere
force-pushed
the
cprivitere/issue709
branch
from
60dc453
to
dd5d715
Compare
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
|
|
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cprivitere, displague The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was incorrect, $(YQ) was missing from the make generate-templates line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes # 709