-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Use same kustomize version as upstream cluster-api #777
✨ Use same kustomize version as upstream cluster-api #777
Conversation
/hold |
- Align version of kustomize to upstream cluster-api - Use upstream method to build kustomize with go install - Add yq to hack tools - Use yq to fix calico yaml formatting (this is the best upstream recommendation to fix kustomize yaml mangling) Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
60dc453
to
dd5d715
Compare
/unhold |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cprivitere, displague The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was incorrect, $(YQ) was missing from the make generate-templates line. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes # 709